Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc: Clean-up and minors pre 1025 #1742

Merged
merged 8 commits into from
Feb 27, 2024
Merged

misc: Clean-up and minors pre 1025 #1742

merged 8 commits into from
Feb 27, 2024

Conversation

mustermeiszer
Copy link
Collaborator

Description

Some minor changes and updates pre 1030 runtime upgrade
Fixes #(issue)

Changes and Descriptions

  • Register new canonical Circle USDC on Celo
  • Rename existing wormhole USDC
    • NOTE: This version is intentionally NOT a variant of LocalUSDC
  • Bumb version of dev runtime
  • Allow Council, root and LpAdmin to set MarketFeeder in the order book for now

Checklist:

  • I have added Rust doc comments to structs, enums, traits and functions
  • I have made corresponding changes to the documentation
  • I have performed a self-review of my code
  • I have added tests that prove my fix is effective or that my feature works

lemunozm
lemunozm previously approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@lemunozm lemunozm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

libs/types/src/tokens.rs
Comment on lines +455 to +457

pub const CURRENCY_ID_LP_CELO_WORMHOLE: CurrencyId = CurrencyId::ForeignAsset(100_004);
pub const CURRENCY_ID_LP_CELO: CurrencyId = CurrencyId::ForeignAsset(100_006);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CURRENCYT_ID_LP_CELO was 100_004, and now it is 100_006. I guess this is the intention of the migration, so wherever we used CURRENCY_ID_LP_CELO, now it's CURRENCY_ID_LP_CELO_WORKHOLE.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exactly!

wischli
wischli previously approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@wischli wischli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wischli wischli changed the title misc: Clean-up and minors pre 1030 misc: Clean-up and minors pre 1025 Feb 27, 2024
@mustermeiszer mustermeiszer dismissed stale reviews from wischli and lemunozm via 5a249f7 February 27, 2024 08:58
@mustermeiszer mustermeiszer enabled auto-merge (squash) February 27, 2024 13:40
@mustermeiszer mustermeiszer merged commit 91f26f9 into main Feb 27, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wischli wischli wischli approved these changes

@lemunozm lemunozm lemunozm left review comments

@gpmayorga gpmayorga Awaiting requested review from gpmayorga gpmayorga is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mustermeiszer @lemunozm @wischli